Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: API hooks #107

Merged
merged 15 commits into from
Jun 11, 2024
Merged

fix: API hooks #107

merged 15 commits into from
Jun 11, 2024
+196 −150

Conversation

farrah-deriv
Copy link
Contributor

Fixed the subscription issues.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@coveralls
Copy link

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9443974619

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 23 of 36 (63.89%) changed or added relevant lines in 15 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 75.162%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/BuySellForm/BuySellForm.tsx 2 3 66.67%
src/hooks/api/advertiser/p2p-advertiser/useAdvertiserInfo.ts 1 3 33.33%
src/hooks/api/settings/p2p-settings/useSettings.ts 1 3 33.33%
src/hooks/api/order/p2p-order/useOrderInfo.ts 1 4 25.0%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/hooks/custom-hooks/useExtendedOrderDetails.ts 1 2.16%
src/pages/orders/components/OrderDetailsCard/OrderDetailsCardFooter/OrderDetailsCardFooter.tsx 1 93.71%
src/pages/my-ads/screens/MyAds/MyAdsTableRow/MyAdsTableRowView.tsx 2 80.46%
Totals Coverage Status
Change from base Build 9416732581: -0.08%
Covered Lines: 4395
Relevant Lines: 5294
💛 - Coveralls

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying deriv-p2p-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7134178
Status: ✅  Deploy successful!
Preview URL: https://ab7082e2.deriv-p2p-app.pages.dev
Branch Preview URL: https://api-hooks-fix.deriv-p2p-app.pages.dev

View logs

@coveralls
Copy link

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9444202772

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 23 of 36 (63.89%) changed or added relevant lines in 15 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 75.162%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/BuySellForm/BuySellForm.tsx 2 3 66.67%
src/hooks/api/advertiser/p2p-advertiser/useAdvertiserInfo.ts 1 3 33.33%
src/hooks/api/settings/p2p-settings/useSettings.ts 1 3 33.33%
src/hooks/api/order/p2p-order/useOrderInfo.ts 1 4 25.0%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/hooks/custom-hooks/useExtendedOrderDetails.ts 1 2.16%
src/pages/orders/components/OrderDetailsCard/OrderDetailsCardFooter/OrderDetailsCardFooter.tsx 1 93.71%
src/pages/my-ads/screens/MyAds/MyAdsTableRow/MyAdsTableRowView.tsx 2 80.46%
Totals Coverage Status
Change from base Build 9416732581: -0.08%
Covered Lines: 4395
Relevant Lines: 5294
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9458744462

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 28 of 41 (68.29%) changed or added relevant lines in 15 files are covered.
  • 90 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.4%) to 74.842%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/BuySellForm/BuySellForm.tsx 2 3 66.67%
src/hooks/api/advertiser/p2p-advertiser/useAdvertiserInfo.ts 1 3 33.33%
src/hooks/api/settings/p2p-settings/useSettings.ts 1 3 33.33%
src/hooks/api/order/p2p-order/useOrderInfo.ts 1 4 25.0%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/hooks/custom-hooks/useExtendedOrderDetails.ts 1 2.16%
src/components/Modals/AdCreateEditSuccessModal/AdCreateEditSuccessModal.tsx 1 90.0%
src/components/BuySellForm/BuySellAmount/index.ts 2 33.33%
src/components/BuySellForm/BuySellData/index.ts 2 33.33%
src/pages/my-ads/screens/MyAds/MyAdsTableRow/MyAdsTableRow.tsx 3 78.76%
src/hooks/api/payment-method/p2p-advertiser-payment-methods/useAdvertiserPaymentMethods.ts 6 28.57%
src/utils/ad-utils.ts 18 38.98%
src/pages/my-ads/screens/CreateEditAd/CreateEditAd.tsx 22 42.27%
src/pages/my-ads/screens/MyAds/MyAdsTableRow/MyAdsTableRowView.tsx 35 60.34%
Totals Coverage Status
Change from base Build 9416732581: -0.4%
Covered Lines: 4490
Relevant Lines: 5423
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9461715817

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 28 of 41 (68.29%) changed or added relevant lines in 15 files are covered.
  • 90 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.2%) to 75.023%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/BuySellForm/BuySellForm.tsx 2 3 66.67%
src/hooks/api/advertiser/p2p-advertiser/useAdvertiserInfo.ts 1 3 33.33%
src/hooks/api/settings/p2p-settings/useSettings.ts 1 3 33.33%
src/hooks/api/order/p2p-order/useOrderInfo.ts 1 4 25.0%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/hooks/custom-hooks/useExtendedOrderDetails.ts 1 2.16%
src/components/Modals/AdCreateEditSuccessModal/AdCreateEditSuccessModal.tsx 1 90.0%
src/components/BuySellForm/BuySellAmount/index.ts 2 33.33%
src/components/BuySellForm/BuySellData/index.ts 2 33.33%
src/pages/my-ads/screens/MyAds/MyAdsTableRow/MyAdsTableRow.tsx 3 78.76%
src/hooks/api/payment-method/p2p-advertiser-payment-methods/useAdvertiserPaymentMethods.ts 6 28.57%
src/utils/ad-utils.ts 18 38.98%
src/pages/my-ads/screens/CreateEditAd/CreateEditAd.tsx 22 42.27%
src/pages/my-ads/screens/MyAds/MyAdsTableRow/MyAdsTableRowView.tsx 35 60.34%
Totals Coverage Status
Change from base Build 9416732581: -0.2%
Covered Lines: 4487
Relevant Lines: 5409
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9461992610

Details

  • 18 of 31 (58.06%) changed or added relevant lines in 13 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 74.848%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/BuySellForm/BuySellForm.tsx 1 2 50.0%
src/hooks/api/advertiser/p2p-advertiser/useAdvertiserInfo.ts 1 3 33.33%
src/hooks/api/settings/p2p-settings/useSettings.ts 1 3 33.33%
src/hooks/api/order/p2p-order/useOrderInfo.ts 1 4 25.0%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/BuySellForm/BuySellForm.tsx 1 82.26%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 1 2.16%
src/pages/my-ads/screens/MyAds/MyAdsTableRow/MyAdsTableRowView.tsx 2 60.34%
Totals Coverage Status
Change from base Build 9461905641: -0.03%
Covered Lines: 4485
Relevant Lines: 5417
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9462431249

Details

  • 18 of 32 (56.25%) changed or added relevant lines in 14 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 74.83%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/BuySellForm/BuySellForm.tsx 1 2 50.0%
src/pages/my-ads/screens/CreateEditAd/CreateEditAd.tsx 0 1 0.0%
src/hooks/api/advertiser/p2p-advertiser/useAdvertiserInfo.ts 1 3 33.33%
src/hooks/api/settings/p2p-settings/useSettings.ts 1 3 33.33%
src/hooks/api/order/p2p-order/useOrderInfo.ts 1 4 25.0%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/BuySellForm/BuySellForm.tsx 1 82.26%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 1 2.16%
src/pages/my-ads/screens/MyAds/MyAdsTableRow/MyAdsTableRowView.tsx 2 60.34%
Totals Coverage Status
Change from base Build 9461905641: -0.05%
Covered Lines: 4485
Relevant Lines: 5418
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Preview Link: https://api-hooks-fix.p2p-standalone.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@farrah-deriv farrah-deriv merged commit 6c86d94 into master Jun 11, 2024
5 checks passed
@coveralls
Copy link

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9462984743

Details

  • 22 of 36 (61.11%) changed or added relevant lines in 15 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 74.782%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/BuySellForm/BuySellForm.tsx 1 2 50.0%
src/pages/my-ads/screens/CreateEditAd/CreateEditAd.tsx 0 1 0.0%
src/hooks/api/advertiser/p2p-advertiser/useAdvertiserInfo.ts 1 3 33.33%
src/hooks/api/settings/p2p-settings/useSettings.ts 1 3 33.33%
src/hooks/api/order/p2p-order/useOrderInfo.ts 1 4 25.0%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/BuySellForm/BuySellForm.tsx 1 82.26%
src/hooks/custom-hooks/useExtendedOrderDetails.ts 1 2.16%
src/pages/my-ads/screens/MyAds/MyAdsTableRow/MyAdsTableRowView.tsx 3 59.54%
Totals Coverage Status
Change from base Build 9461905641: -0.1%
Covered Lines: 4486
Relevant Lines: 5419
💛 - Coveralls

@ali-hosseini-deriv ali-hosseini-deriv deleted the api-hooks-fix branch August 16, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameerul-deriv ameerul-deriv ameerul-deriv left review comments

@nada-deriv nada-deriv nada-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@azmib-developer azmib-developer Awaiting requested review from azmib-developer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@farrah-deriv @coveralls @ameerul-deriv @nada-deriv